netdev - Re: [PATCH net v2] qed: Fix uninitialized data in aRFS infrastructure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a2HNAPOrwr+RQ0gGkjs64aKr3=C2VgNwqgqN9+yaNa6JQ@mail.gmail.com>
Date:   Mon, 15 May 2017 16:35:34 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Yuval Mintz <Yuval.Mintz@...ium.com>
Cc:     David Miller <davem@...emloft.net>,
        Networking <netdev@...r.kernel.org>
Subject: Re: [PATCH net v2] qed: Fix uninitialized data in aRFS infrastructure

On Sun, May 14, 2017 at 11:21 AM, Yuval Mintz <Yuval.Mintz@...ium.com> wrote:
> Current memset is using incorrect type of variable, causing the
> upper-half of the strucutre to be left uninitialized and causing:
>
>   ethernet/qlogic/qed/qed_init_fw_funcs.c: In function 'qed_set_rfs_mode_disable':
>   ethernet/qlogic/qed/qed_init_fw_funcs.c:993:3: error: '*((void *)&ramline+4)' is used uninitialized in this function [-Werror=uninitialized]
>
> Fixes: d51e4af5c209 ("qed: aRFS infrastructure support")
> Reported-by: Arnd Bergmann <arnd@...db.de>
> Signed-off-by: Yuval Mintz <Yuval.Mintz@...ium.com>

> I don't see the original warning you've reported [probably due to
> compiler differences], so other than via code reading I couldn't
> actually test this. Can you please compile-test this one?

I don't see the warning any more either with the compiler and defconfig
I used last time, maybe some compiler flags have changed in the
meantime.

Anyway, your patch is definitely required to make it work correctly, so

Reviewed-by: Arnd Bergmann <arnd@...db.de>

       Arnd