netdev - Re: [PATCH 1/2] net-next: stmmac: add adjust

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170516.123809.1468879091622494215.davem@davemloft.net>
Date:   Tue, 16 May 2017 12:38:09 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     clabbe.montjoie@...il.com
Cc:     peppe.cavallaro@...com, alexandre.torgue@...com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] net-next: stmmac: add adjust_link function

From: Corentin Labbe <clabbe.montjoie@...il.com>
Date: Mon, 15 May 2017 13:41:39 +0200

> My dwmac-sun8i serie will add some if (has_sun8i) to
> stmmac_adjust_link()
> Since the current stmmac_adjust_link() alreaady have lots of if (has_gmac/gmac4),
> It is now better to create an adjust_link() function for each dwmac.
> 
> So this patch add an adjust_link() function pointer, and move code out
> of stmmac_adjust_link to it.
> 
> Removing in the process stmmac_mac_flow_ctrl/stmmac_hw_fix_mac_speed
> since there not used anymore.
> 
> Signed-off-by: Corentin Labbe <clabbe.montjoie@...il.com>

This will introduce crashes because you only added the adjust_link
method to one of the two stmmac_ops instances in
drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c

Furthermore, a patch series should always have a header posting
with subject of the format "[PATCH 0/N]: xxx" which describes at
a high level what the patch series does as a whole, how it is doing
it, and why it is doing it that way.

Thank you.