netdev - Re: [PATCH] ipmr: vrf: Find VIFs using the actual device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <11682335-6d21-f8d1-0b20-7ea47a236823@gmail.com>
Date:   Mon, 15 May 2017 21:50:46 -0700
From:   David Ahern <dsahern@...il.com>
To:     Thomas Winter <Thomas.Winter@...iedtelesis.co.nz>,
        netdev@...r.kernel.org
Cc:     David Ahern <dsa@...ulusnetworks.com>,
        Nikolay Aleksandrov <nikolay@...ulusnetworks.com>,
        roopa <roopa@...ulusnetworks.com>
Subject: Re: [PATCH] ipmr: vrf: Find VIFs using the actual device

On 5/15/17 3:14 PM, Thomas Winter wrote:
> The skb->dev that is passed into ip_mr_input is
> the loX device for VRFs. When we lookup a vif
> for this dev, none is found as we do not create
> vifs for loopbacks. Instead lookup a vif for the
> actual device that the packet was received on,
> eg the vlan.
> 
> Signed-off-by: Thomas Winter <Thomas.Winter@...iedtelesis.co.nz>
> cc: David Ahern <dsa@...ulusnetworks.com>
> cc: Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
> cc: roopa <roopa@...ulusnetworks.com>
> ---
>  net/ipv4/ipmr.c | 18 ++++++++++++++++--
>  1 file changed, 16 insertions(+), 2 deletions(-)

LGTM

Acked-by: David Ahern <dsahern@...il.com>