netdev - Re: [PATCH net-next] geneve: add rtnl changelink support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170516.153115.2084299272043901950.davem@davemloft.net>
Date:   Tue, 16 May 2017 15:31:15 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     girish.moodalbail@...cle.com
Cc:     netdev@...r.kernel.org, pshelar@....org, joe@....org,
        jbenc@...hat.com
Subject: Re: [PATCH net-next] geneve: add rtnl changelink support

From: Girish Moodalbail <girish.moodalbail@...cle.com>
Date: Mon, 15 May 2017 10:47:04 -0700

>  	if (data[IFLA_GENEVE_REMOTE]) {
> -		info.key.u.ipv4.dst =
> +		info->key.u.ipv4.dst =
>  			nla_get_in_addr(data[IFLA_GENEVE_REMOTE]);
>  
> -		if (IN_MULTICAST(ntohl(info.key.u.ipv4.dst))) {
> +		if (IN_MULTICAST(ntohl(info->key.u.ipv4.dst))) {
>  			netdev_dbg(dev, "multicast remote is unsupported\n");
>  			return -EINVAL;
>  		}
> +		if (changelink &&
> +		    ip_tunnel_info_af(&geneve->info) == AF_INET6) {
> +			info->mode &= ~IP_TUNNEL_INFO_IPV6;
> +			info->key.tun_flags &= ~TUNNEL_CSUM;
> +			*use_udp6_rx_checksums = false;
> +		}
>  	}

I don't understand this "changelink" guarded code, why do you need to
clear all of this state out if the existing tunnel type if AF_INET6
and only when doing a changelink?

In any event, I think you need to add a comment explaining it.