lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20170516210038.GR1939@nanopsycho.orion> Date: Tue, 16 May 2017 23:00:38 +0200 From: Jiri Pirko <jiri@...nulli.us> To: Cong Wang <xiyou.wangcong@...il.com> Cc: Linux Kernel Network Developers <netdev@...r.kernel.org>, David Miller <davem@...emloft.net>, Jamal Hadi Salim <jhs@...atatu.com>, David Ahern <dsa@...ulusnetworks.com>, Eric Dumazet <edumazet@...gle.com>, Stephen Hemminger <stephen@...workplumber.org>, Daniel Borkmann <daniel@...earbox.net>, Alexander Duyck <alexander.h.duyck@...el.com>, Simon Horman <simon.horman@...ronome.com>, mlxsw@...lanox.com Subject: Re: [patch net-next v3 01/10] net: sched: move tc_classify function to cls_api.c Tue, May 16, 2017 at 10:25:35PM CEST, xiyou.wangcong@...il.com wrote: >On Tue, May 16, 2017 at 10:27 AM, Jiri Pirko <jiri@...nulli.us> wrote: >> From: Jiri Pirko <jiri@...lanox.com> >> >> Move tc_classify function to cls_api.c where it belongs, rename it to >> fit the namespace. >> > >It is not a pure move, you silently remove the CONFIG_NET_CLS_ACT >macros in tc_classify(). Probably not buggy, just redundancy when >actions are not compiled. Plese see include/net/pkt_cls.h in this patch. If CONFIG_NET_CLS_ACT is not defined, there is a stub there.
Powered by blists - more mailing lists