netdev - Re: [PATCH net] selftests/bpf: fix broken build due to types.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a476038c-62a5-5690-c776-e5f08d120d1a@fb.com>
Date:   Tue, 16 May 2017 16:16:25 -0700
From:   Yonghong Song <yhs@...com>
To:     David Miller <davem@...emloft.net>
CC:     <daniel@...earbox.net>, <netdev@...r.kernel.org>,
        <kernel-team@...com>
Subject: Re: [PATCH net] selftests/bpf: fix broken build due to types.h



On 5/16/17 12:18 PM, David Miller wrote:
> 
> Please correct the address of the netdev list (it is just plain
> 'netdev' not 'linux-netdev').

Thanks. Shortly after my first email, I sent a corrected submit as well.
Sorry for the spam.

> 
> Secondly, __always_inline should not be defined by types.h
> 
> That has to come from linux/compiler.h which we have no reason
> to define a private version of for eBPF clang compilation.
> 
> The problem is that via several layers of indirection, linux/types.h
> eventually includes linux/compiler.h and that is probably the more
> appropriate thing for you to do.

Right. I found out simply including string.h will eventually include
linux/compiler.h so that I do not need explicitly defining
__always_inline.

Will send a revised patch soon.

Thanks,

Yonghong

>