netdev - Re: [patch net-next v2 04/10] net: sched: replace nprio by a bool to make the function more readable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0553194d-9d76-bb39-4b29-c3c734a6ff44@mojatatu.com>
Date:   Tue, 16 May 2017 08:09:25 -0400
From:   Jamal Hadi Salim <jhs@...atatu.com>
To:     Jiri Pirko <jiri@...nulli.us>, netdev@...r.kernel.org
Cc:     davem@...emloft.net, xiyou.wangcong@...il.com,
        dsa@...ulusnetworks.com, edumazet@...gle.com,
        stephen@...workplumber.org, daniel@...earbox.net,
        alexander.h.duyck@...el.com, simon.horman@...ronome.com,
        mlxsw@...lanox.com
Subject: Re: [patch net-next v2 04/10] net: sched: replace nprio by a bool to
 make the function more readable

On 17-05-15 04:38 AM, Jiri Pirko wrote:

> diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c
> index 88ec1a1..0e49e6e 100644
> --- a/net/sched/cls_api.c
> +++ b/net/sched/cls_api.c
> @@ -271,7 +271,7 @@ static int tc_ctl_tfilter(struct sk_buff *skb, struct nlmsghdr *n,
>  	struct tcmsg *t;
>  	u32 protocol;
>  	u32 prio;
> -	u32 nprio;
> +	bool prio_allocate;

prio_allocated? (past tense seems more sensible)

cheers,
jamal