lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20170516124255.GA5440@redhat.com> Date: Tue, 16 May 2017 14:43:41 +0200 From: Stanislaw Gruszka <sgruszka@...hat.com> To: Johannes Berg <johannes@...solutions.net> Cc: David Miller <davem@...emloft.net>, arnd@...db.de, helmut.schaa@...glemail.com, kvalo@...eaurora.org, daniel@...rotopia.org, dev@...sin.me, pozega.tomislav@...il.com, vasilugin@...dex.ru, roman@...em.lv, linux-wireless@...r.kernel.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] rt2x00: improve calling conventions for register accessors On Tue, May 16, 2017 at 01:58:56PM +0200, Johannes Berg wrote: > On Tue, 2017-05-16 at 13:55 +0200, Stanislaw Gruszka wrote: > > > > In rt2x00 driver we use poor convention in other kind of registers > > accessors like bbp, mac, eeprom. I dislike to changing only rfcsr > > accessors and leaving others in the old way. And changing all > > accessors would be massive and error prone change, which I'm not > > prefer either. > > That's a stupid argument, but for the sake of it - the conversion can > easily be done with coccinelle/spatch without being "error prone". Sure, but still I think it would be preferable to fix newly added rt2800_bw_filter_calibration() function, instead of ancient rfcsr accessors. Stanislaw
Powered by blists - more mailing lists