netdev - Re: [net-next] net: remove duplicate add_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170517.111758.1634488202115561021.davem@davemloft.net>
Date:   Wed, 17 May 2017 11:17:58 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     zhangshengju@...s.chinamobile.com
Cc:     netdev@...r.kernel.org
Subject: Re: [net-next] net: remove duplicate add_device_randomness() call

From: Zhang Shengju <zhangshengju@...s.chinamobile.com>
Date: Wed, 17 May 2017 17:23:26 +0800

> Since register_netdevice() already call add_device_randomness() and
> dev_set_mac_address() will call it after mac address change.
> It's not necessary to call at device UP.
> 
> Signed-off-by: Zhang Shengju <zhangshengju@...s.chinamobile.com>

__dev_open() can (at least theroretically) do things which adjust the
MAC address, and therefore the add_device_randomness() call is
appropriate.

And even if ->ndo_open() implementations do not do so currently, I
do not want to prevent it from doing so.

I am not applying this patch, sorry.