netdev - Re: [PATCH net-next] cxgb4: keep carrier off after registering netdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170517.120158.815958672031647352.davem@davemloft.net>
Date:   Wed, 17 May 2017 12:01:58 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     ganeshgr@...lsio.com
Cc:     netdev@...r.kernel.org, nirranjan@...lsio.com,
        indranil@...lsio.com, surendra@...lsio.com
Subject: Re: [PATCH net-next] cxgb4: keep carrier off after registering
 netdev

From: Ganesh Goudar <ganeshgr@...lsio.com>
Date: Tue, 16 May 2017 21:26:25 +0530

> From: Surendra Mobiya <surendra@...lsio.com>
> 
> Mark carrier off after registering netdev to ensure that vlan device
> picks up the correct state of the carrier
> 
> Signed-off-by: Surendra Mobiya <surendra@...lsio.com>
> Signed-off-by: Ganesh Goudar <ganeshgr@...lsio.com>

This doesn't work.

At the very moment you perform the register netdev, it can be
openned, stacked onto other devices (like VLANs) etc. before
your line doing the carrier off occurs.

So once you do the netdev register, all the state must be
completely settled beforehand.