lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <ae02e4e8-3047-cd42-9c53-a2a38f8c28df@mojatatu.com> Date: Wed, 17 May 2017 08:18:00 -0400 From: Jamal Hadi Salim <jhs@...atatu.com> To: Jiri Pirko <jiri@...nulli.us>, netdev@...r.kernel.org Cc: davem@...emloft.net, xiyou.wangcong@...il.com, dsa@...ulusnetworks.com, edumazet@...gle.com, stephen@...workplumber.org, daniel@...earbox.net, alexander.h.duyck@...el.com, simon.horman@...ronome.com, mlxsw@...lanox.com Subject: Re: [patch net-next v4 06/10] net: sched: introduce helpers to work with filter chains On 17-05-17 05:07 AM, Jiri Pirko wrote: > From: Jiri Pirko <jiri@...lanox.com> > > Introduce struct tcf_chain object and set of helpers around it. Wraps up > insertion, deletion and search in the filter chain. > > Signed-off-by: Jiri Pirko <jiri@...lanox.com> > --- [..] > + > +static void > +tcf_chain_filter_chain_ptr_set(struct tcf_chain *chain, > + struct tcf_proto __rcu **p_filter_chain) > + What are the rules for this? Common coding style is: static void tcf_chain_filter_chain_ptr_set(struct tcf_chain *chain, struct tcf_proto .. I am sure that struct tcf_proto __rcu **p_filter_chain would probably hit boundary of 80 chars - but it would look cleaner to be consistent. Otherwise: Acked-by: Jamal Hadi Salim <jhs@...atatu.com> cheers, jamal
Powered by blists - more mailing lists