netdev - Re: [PATCH net-next v2] net: fix __skb_try_recv_from

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170518.103319.1210941190107364339.davem@davemloft.net>
Date:   Thu, 18 May 2017 10:33:19 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     avagin@...nvz.org
Cc:     netdev@...r.kernel.org, pabeni@...hat.com, edumazet@...gle.com
Subject: Re: [PATCH net-next v2] net: fix __skb_try_recv_from_queue to
 return the old behavior

From: Andrei Vagin <avagin@...nvz.org>
Date: Wed, 17 May 2017 11:39:05 -0700

> This function has to return NULL on a error case, because there is a
> separate error variable.
> 
> The offset has to be changed only if skb is returned
> 
> v2: fix udp code to not use an extra variable
> 
> Cc: Paolo Abeni <pabeni@...hat.com>
> Cc: Eric Dumazet <edumazet@...gle.com>
> Cc: David S. Miller <davem@...emloft.net>
> Fixes: 65101aeca522 ("net/sock: factor out dequeue/peek with offset cod")
> Signed-off-by: Andrei Vagin <avagin@...nvz.org>

Applied.