netdev - Re: [PATCH] ip6_tunnel, ip6_gre: fix setting of DSCP on encapsulated packets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CANX4UBcureLm+7wkC1C6=ZvV4JNTKzSCvzv-hV=w77O_WF4ntA@mail.gmail.com>
Date:   Thu, 18 May 2017 12:49:01 +1000
From:   Peter Dawson <petedaws@...il.com>
To:     stephen@...workplumber.org
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH] ip6_tunnel, ip6_gre: fix setting of DSCP on encapsulated packets

>> This fix addresses two problems in the way the DSCP field is
>> formulated on the  encapsulating header of IPv6 tunnels.
>> This fix addresses Bug 195661.
>> https://bugzilla.kernel.org/show_bug.cgi?id=195661
>>
>> 1) The IPv6 tunneling code was manipulating the DSCP field of the
>> encapsulating  packet using the 32b flowlabel. Since the flowlabel is
>> only the lower 20b it  was incorrect to assume that the upper 12b
>> containing the DSCP and ECN fields  would remain intact when
>> formulating the encapsulating header. This fix  handles the 'inherit'
>> and 'fixed-value' DSCP cases explicitly using the extant  dsfield u8 variable.
>>
>> 2) The use of INET_ECN_encapsulate(0, dsfield) in ip6_tnl_xmit was
>> incorrect  and resulted in the DSCP value always being set to 0.
>> ---
>>  net/ipv6/ip6_gre.c    | 18 ++++++++++--------
>>  net/ipv6/ip6_tunnel.c | 28 +++++++++++++++++-----------
>>  2 files changed, 27 insertions(+), 19 deletions(-)
>
> This patch looks correct, but has trivial style issues like using spaces instead of tabs and other junk.  Please run checkpatch.pl, look at the results and resubmit.

Thanks.  I've run checkpatch.pl over this updated file with no errors.
Regards
Peter

View attachment "tunnel_inherit.patch" of type "text/x-diff" (5709 bytes)