netdev - Re: [PATCH net-next] tcp: fix tcp_rearm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170518.132059.1279235795595365192.davem@davemloft.net>
Date:   Thu, 18 May 2017 13:20:59 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     eric.dumazet@...il.com
Cc:     edumazet@...gle.com, ncardwell@...gle.com, ycheng@...gle.com,
        soheil@...gle.com, weiwan@...gle.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] tcp: fix tcp_rearm_rto()

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Thu, 18 May 2017 09:15:58 -0700

> From: Eric Dumazet <edumazet@...gle.com>
> 
> skbs in (re)transmit queue no longer have a copy of jiffies
> at the time of the transmit : skb->skb_mstamp is now in usec unit,
> with no correlation to tcp_jiffies32.
> 
> We have to convert rto from jiffies to usec, compute a time difference
> in usec, then convert the delta to HZ units.
> 
> Fixes: 9a568de4818d ("tcp: switch TCP TS option (RFC 7323) to 1ms clock")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied, thanks Eric.