lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <87lgpuco7t.fsf@miraculix.mork.no> Date: Thu, 18 May 2017 15:02:30 +0200 From: Bjørn Mork <bjorn@...k.no> To: Oliver Neukum <oneukum@...e.com> Cc: netdev@...r.kernel.org Subject: Re: [RFC]RNDIS filter issue Oliver Neukum <oneukum@...e.com> writes: > @@ -472,7 +489,6 @@ static void usbnet_cdc_zte_status(struct usbnet *dev, struct urb *urb) > > if (urb->actual_length < sizeof(*event)) > return; > - > event = urb->transfer_buffer; > > if (event->bNotificationType != USB_CDC_NOTIFY_NETWORK_CONNECTION) { Spurious whitespace. And building gives: /usr/local/src/git/linux/drivers/net/usb/cdc_ether.c:325:5: warning: symbol 'usbnet_ether_cdc_bind' was not declared. Should it be static? and maybe it should? There is no use for it in any other module, yet. Or you could declare it in usbnet.h, I guess. Your choice. Looks good to me if those two minor issues are fixed. But do note that I currently don't have any way to test this on real hardware... Bjørn
Powered by blists - more mailing lists