netdev - Re: [PATCH net-next] net: make struct net_device::tx_queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170518.102001.715764939763640042.davem@davemloft.net>
Date:   Thu, 18 May 2017 10:20:01 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     adobriyan@...il.com
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: make struct net_device::tx_queue_len
 unsigned int

From: Alexey Dobriyan <adobriyan@...il.com>
Date: Wed, 17 May 2017 13:30:44 +0300

> 4 billion packet queue is something unthinkable so use 32-bit value
> for now.
> 
> Space savings on x86_64:
> 
> 	add/remove: 0/0 grow/shrink: 3/70 up/down: 16/-131 (-115)
> 	function                                     old     new   delta
> 	change_tx_queue_len                           94     108     +14
> 	qdisc_create                                1176    1177      +1
> 	alloc_netdev_mqs                            1124    1125      +1
> 	xenvif_alloc                                 533     532      -1
> 	x25_asy_setup                                167     166      -1
> 			...
> 	tun_queue_resize                             945     940      -5
> 	pfifo_fast_enqueue                           167     162      -5
> 	qfq_init_qdisc                               168     158     -10
> 	tap_queue_resize                             810     799     -11
> 	transmit                                     719     698     -21
> 
> Signed-off-by: Alexey Dobriyan <adobriyan@...il.com>

Applied.