netdev - Re: [PATCH net-next v2] bridge: fix hello and hold timers starting/stopping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6c14d4a9-0fc8-aa28-7c73-99ad5e0fbef5@cumulusnetworks.com>
Date:   Fri, 19 May 2017 23:12:45 +0300
From:   Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
To:     Ivan Vecera <cera@...a.cz>, netdev@...r.kernel.org
Cc:     davem@...emloft.net, sashok@...ulusnetworks.com,
        stephen@...workplumber.org, bridge@...ts.linux-foundation.org,
        lucien.xin@...il.com
Subject: Re: [PATCH net-next v2] bridge: fix hello and hold timers
 starting/stopping

On 5/19/17 8:30 PM, Ivan Vecera wrote:
> Current bridge code incorrectly handles starting/stopping of hello and
> hold timers during STP enable/disable.
> 
> 1. Timers are stopped in br_stp_start() during NO_STP->USER_STP
>     transition. The timers are already stopped in NO_STP state so
>     this is confusing no-op.
> 
> 2. During USER_STP->NO_STP transition the timers are started. This
>     does not make sense and is confusion because the timer should not be
>     active in NO_STP state.
> 
> Cc: davem@...emloft.net
> Cc: sashok@...ulusnetworks.com
> Cc: stephen@...workplumber.org
> Cc: bridge@...ts.linux-foundation.org
> Cc: lucien.xin@...il.com
> Cc: nikolay@...ulusnetworks.com
> Signed-off-by: Ivan Vecera <cera@...a.cz>
> ---
>   net/bridge/br_stp_if.c | 11 -----------
>   1 file changed, 11 deletions(-)
> 

LGTM, thanks!

Acked-by: Nikolay Aleksandrov <nikolay@...ulusnetworks.com>