netdev - Re: ath5k: fix memory leak on buf on failed eeprom read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <31364cad256e4b409906f66efd7dd6d0@euamsexm01a.eu.qualcomm.com>
Date:   Fri, 19 May 2017 09:52:27 +0200
From:   Kalle Valo <kvalo@....qualcomm.com>
To:     Colin Ian King <colin.king@...onical.com>
CC:     Jiri Slaby <jirislaby@...il.com>,
        Nick Kossifidis <mickflemm@...il.com>,
        "Luis R . Rodriguez" <mcgrof@...not-panic.com>,
        Kalle Valo <kvalo@...eaurora.org>,
        <linux-wireless@...r.kernel.org>,
        <kernel-janitors@...r.kernel.org>, <netdev@...r.kernel.org>
Subject: Re: ath5k: fix memory leak on buf on failed eeprom read

Colin Ian King <colin.king@...onical.com> wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> The AR5K_EEPROM_READ macro returns with -EIO if a read error
> occurs causing a memory leak on the allocated buffer buf. Fix
> this by explicitly calling ath5k_hw_nvram_read and exiting on
> the via the freebuf label that performs the necessary free'ing
> of buf when a read error occurs.
> 
> Detected by CoverityScan, CID#1248782 ("Resource Leak")
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Patch applied to ath-next branch of ath.git, thanks.

8fed6823e06e ath5k: fix memory leak on buf on failed eeprom read

-- 
https://patchwork.kernel.org/patch/9709935/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches