netdev - Re: [PATCH 0/4] Configuring traffic classes via new hardware offload mechanism in tc/mqprio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJ3xEMjTDW7sQ5CFmTyR5xMpin_WFFQg-S8imWMBpXWuS1zvVw@mail.gmail.com>
Date:   Sun, 21 May 2017 00:15:02 +0300
From:   Or Gerlitz <gerlitz.or@...il.com>
To:     Amritha Nambiar <amritha.nambiar@...el.com>
Cc:     intel-wired-lan <intel-wired-lan@...ts.osuosl.org>,
        Alexander Duyck <alexander.h.duyck@...el.com>,
        kiran.patil@...el.com,
        "Samudrala, Sridhar" <sridhar.samudrala@...el.com>,
        Mitch Williams <mitch.a.williams@...el.com>,
        Neerav Parikh <neerav.parikh@...el.com>,
        Jeff Kirsher <jeffrey.t.kirsher@...el.com>,
        Linux Netdev List <netdev@...r.kernel.org>
Subject: Re: [PATCH 0/4] Configuring traffic classes via new hardware offload
 mechanism in tc/mqprio

On Sat, May 20, 2017 at 3:58 AM, Amritha Nambiar
<amritha.nambiar@...el.com> wrote:
> The following series introduces a new harware offload mode in tc/mqprio

Wait, we have already a HW QoS model introduced by John F and Co
couple of years ago,  right?

Please elaborate in few sentence if you are extending it/replacing it,
why we want to do that and what are the implications on existing
applications UAPI wise.

Below you just say in the new mode Qos is configured with knobs XYZ --
this is way not enough

> where the TCs, the queue configurations and bandwidth rate limits
> are offloaded to the hardware.


> The i40e driver enables the new mqprio hardware offload mechanism factoring the TCs, queue configuration and bandwidth rates by creating HW channel VSIs.
>
> In this mode, the priority to traffic class mapping and the user specified queue ranges are used to configure the traffic class when the 'hw' option is set to 2. This is achieved by creating HW channels(VSI). A new channel is created for each of the traffic class configuration offloaded via mqprio framework except for the first TC (TC0) which is for the main VSI. TC0 for the main VSI is also reconfigured as per user provided queue parameters. Finally, bandwidth rate limits are set on these traffic classes through the mqprio offload framework by sending these rates in addition to the number of TCs and the queue configurations.