netdev - RE: [PATCH v3 net-next 1/5] dsa: add support for Microchip KSZ tail tagging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9235D6609DB808459E95D78E17F2E43D40A7D1B8@CHN-SV-EXMX02.mchp-main.com>
Date:   Sat, 20 May 2017 02:12:04 +0000
From:   <Woojung.Huh@...rochip.com>
To:     <f.fainelli@...il.com>, <andrew@...n.ch>,
        <vivien.didelot@...oirfairelinux.com>,
        <sergei.shtylyov@...entembedded.com>
CC:     <netdev@...r.kernel.org>, <davem@...emloft.net>,
        <UNGLinuxDriver@...rochip.com>
Subject: RE: [PATCH v3 net-next 1/5] dsa: add support for Microchip KSZ tail
 tagging

>> +     if (padlen) {
>> +             u8 *pad = skb_put(nskb, padlen);
>> +
>> +             memset(pad, 0, padlen);
>> +     }
>
>Can you use skb_put_padto() here instead of open coding this?
>
>> +
>> +     tag = skb_put(nskb, KSZ_INGRESS_TAG_LEN);
>> +     tag[0] = 0;
>> +     tag[1] = 1 << p->dp->index; /* destnation port */
>
>typo: destination port
>
>With that fixed:
>
>Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
HI Florian,

Thanks for prompt reviews. Will submit another version.

- Woojung