lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <e0b336e6-538e-eeea-0ed4-33460dbef7e0@suse.de> Date: Sun, 21 May 2017 16:54:01 +0200 From: Andreas Färber <afaerber@...e.de> To: Martin Blumenstingl <martin.blumenstingl@...glemail.com>, kvalo@...eaurora.org, robh+dt@...nel.org, mark.rutland@....com, devicetree@...r.kernel.org Cc: linux-wireless@...r.kernel.org, netdev@...r.kernel.org, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, Maxime Ripard <maxime.ripard@...e-electrons.com>, Chen-Yu Tsai <wens@...e.org>, Shawn Guo <shawnguo@...nel.org>, Sascha Hauer <kernel@...gutronix.de>, Fabio Estevam <fabio.estevam@....com> Subject: Re: [PATCH 1/1] dt-binding: net: wireless: fix node name in the BCM43xx example Am 15.05.2017 um 22:13 schrieb Martin Blumenstingl: > The example in the BCM43xx documentation uses "brcmf" as node name. No, it doesn't, it uses "bcrmf". This typo has spread to all ARM device trees: $ git grep bcrmf -- arch/arm/boot/dts/ arch/arm/boot/dts/imx6sx-nitrogen6sx.dts: brcmf: bcrmf@1 { arch/arm/boot/dts/imx6ul-opos6ul.dtsi: brcmf: bcrmf@1 { arch/arm/boot/dts/sun6i-a31s-sinovoip-bpi-m2.dts: brcmf: bcrmf@1 { arch/arm/boot/dts/sun7i-a20-bananapi-m1-plus.dts: brcmf: bcrmf@1 { arch/arm/boot/dts/sun7i-a20-bananapro.dts: brcmf: bcrmf@1 { arch/arm/boot/dts/sun7i-a20-cubietruck.dts: brcmf: bcrmf@1 { arch/arm/boot/dts/sun7i-a20-i12-tvbox.dts: brcmf: bcrmf@1 { arch/arm/boot/dts/sun7i-a20-wits-pro-a20-dkt.dts: brcmf: bcrmf@1 { arch/arm/boot/dts/sun8i-h3-bananapi-m2-plus.dts: brcmf: bcrmf@1 { For arch/arm64/boot/dts/amlogic/* I've already fixed it, originally by changing to "brcmf", in a second step "wifi" was requested. > However, wireless devices should be named "wifi" instead. Fix this to > make sure that .dts authors can simply use the documentation as > reference (or simply copy the node from the documentation and then > adjust only the board specific bits). > > Signed-off-by: Martin Blumenstingl <martin.blumenstingl@...glemail.com> > --- > Documentation/devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt b/Documentation/devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt > index 5dbf169cd81c..590f622188de 100644 > --- a/Documentation/devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt > +++ b/Documentation/devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt > @@ -31,7 +31,7 @@ mmc3: mmc@...12000 { > non-removable; > status = "okay"; > > - brcmf: bcrmf@1 { > + brcmf: wifi@1 { > reg = <1>; > compatible = "brcm,bcm4329-fmac"; > interrupt-parent = <&pio>; Thanks for fixing this at its source. Hopefully the maintainers in CC can make sure that at least it doesn't spread further into new DTs. Regards, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg)
Powered by blists - more mailing lists