netdev - Re: [PATCH net-next 9/9] ipv6: remove unused variables in esp6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170521.134436.268347108365784579.davem@davemloft.net>
Date:   Sun, 21 May 2017 13:44:36 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     stephen@...workplumber.org
Cc:     netdev@...r.kernel.org, sthemmin@...rosoft.com,
        steffen.klassert@...unet.com
Subject: Re: [PATCH net-next 9/9] ipv6: remove unused variables in esp6

From: Stephen Hemminger <stephen@...workplumber.org>
Date: Fri, 19 May 2017 09:55:56 -0700

> Resolves warnings:
> net/ipv6/esp6.c: In function ‘esp_ssg_unref’:
> net/ipv6/esp6.c:121:10: warning: variable ‘seqhi’ set but not used [-Wunused-but-set-variable]
> net/ipv6/esp6.c: In function ‘esp6_output_head’:
> net/ipv6/esp6.c:227:21: warning: variable ‘esph’ set but not used [-Wunused-but-set-variable]
> 
> Signed-off-by: Stephen Hemminger <sthemmin@...rosoft.com>

Stephen please always CC: the IPSEC maintainer for IPSEC implementation
fixes.

Steffen, please consider taking this into your tree.

> ---
>  net/ipv6/esp6.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/net/ipv6/esp6.c b/net/ipv6/esp6.c
> index 1fe99ba8066c..53b6b870b935 100644
> --- a/net/ipv6/esp6.c
> +++ b/net/ipv6/esp6.c
> @@ -118,7 +118,6 @@ static inline struct scatterlist *esp_req_sg(struct crypto_aead *aead,
>  
>  static void esp_ssg_unref(struct xfrm_state *x, void *tmp)
>  {
> -	__be32 *seqhi;
>  	struct crypto_aead *aead = x->data;
>  	int seqhilen = 0;
>  	u8 *iv;
> @@ -128,7 +127,6 @@ static void esp_ssg_unref(struct xfrm_state *x, void *tmp)
>  	if (x->props.flags & XFRM_STATE_ESN)
>  		seqhilen += sizeof(__be32);
>  
> -	seqhi = esp_tmp_seqhi(tmp);
>  	iv = esp_tmp_iv(aead, tmp, seqhilen);
>  	req = esp_tmp_req(aead, iv);
>  
> @@ -224,12 +222,9 @@ int esp6_output_head(struct xfrm_state *x, struct sk_buff *skb, struct esp_info
>  	u8 *vaddr;
>  	int nfrags;
>  	struct page *page;
> -	struct ip_esp_hdr *esph;
>  	struct sk_buff *trailer;
>  	int tailen = esp->tailen;
>  
> -	esph = ip_esp_hdr(skb);
> -
>  	if (!skb_cloned(skb)) {
>  		if (tailen <= skb_availroom(skb)) {
>  			nfrags = 1;
> -- 
> 2.11.0
>