netdev - Re: [PATCH net-next] tcp: fix tcp_probe_timer() for TCP_USER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1495389688.6465.54.camel@edumazet-glaptop3.roam.corp.google.com>
Date:   Sun, 21 May 2017 11:01:28 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Soheil Hassas Yeganeh <soheil@...gle.com>
Cc:     David Miller <davem@...emloft.net>, netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] tcp: fix tcp_probe_timer() for TCP_USER_TIMEOUT

On Sun, 2017-05-21 at 13:46 -0400, Soheil Hassas Yeganeh wrote:
> On Sun, May 21, 2017 at 1:39 PM, Eric Dumazet <eric.dumazet@...il.com> wrote:
> > From: Eric Dumazet <edumazet@...gle.com>
> >
> > TCP_USER_TIMEOUT is still converted to jiffies value in
> > icsk_user_timeout
> >
> > So we need to make a conversion for the cases HZ != 1000
> >
> > Fixes: 9a568de4818d ("tcp: switch TCP TS option (RFC 7323) to 1ms clock")
> > Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> 
> Acked-by: Soheil Hassas Yeganeh <soheil@...gle.com>
> 
> Thank you for the fix, Eric!

Thanks for reviewing !