netdev - Re: [PATCH net-next v5] net: ipv6: fix code style error and warning of ndisc.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 21 May 2017 14:14:38 -0700
From:   Joe Perches <joe@...ches.com>
To:     David Miller <davem@...emloft.net>, dsahern@...il.com
Cc:     cugyly@....com, netdev@...r.kernel.org,
        Linyu.Yuan@...atel-sbell.com.cn
Subject: Re: [PATCH net-next v5] net: ipv6: fix code style error and warning
 of ndisc.c

On Sun, 2017-05-21 at 12:54 -0400, David Miller wrote:
> From: David Ahern <dsahern@...il.com> Date: Sun, 21 May 2017 10:17:47 -0600
> > On 5/21/17 10:05 AM, Joe Perches wrote:
> >> But really, why bother?
> >> 
> >> Just because checkpatch bleats some message doesn't
> >> mean it _has_ to be fixed.
> >> 
> >> Please strive to make the code more readable and
> >> intelligible for _humans_.  Compilers don't care.
> > 
> > +1
> > 
> > broad cleanups like this make 'git blame' harder to use to find root causes.

I don't have any issue with broad cleanups and I think
the git blame argument is overblown.

If and when broad cleanups are done, it's best if there
is some other concurrent desire to improve logic, reduce
object code size, and/or other code refactoring other
than mere whitespace changes.