netdev - Re: [PATCH] net: atheros: atl2: don't return zero on failure path in atl2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170522.120517.186219063658821306.davem@davemloft.net>
Date:   Mon, 22 May 2017 12:05:17 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     khoroshilov@...ras.ru
Cc:     jcliburn@...il.com, chris.snook@...il.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, ldv-project@...uxtesting.org
Subject: Re: [PATCH] net: atheros: atl2: don't return zero on failure path
 in atl2_probe()

From: Alexey Khoroshilov <khoroshilov@...ras.ru>
Date: Sat, 20 May 2017 01:52:11 +0300

> If dma mask checks fail in atl2_probe(), it breaks off initialization,
> deallocates all resources, but returns zero.
> 
> The patch adds proper error code return value and
> make error code setup unified.
> 
> Found by Linux Driver Verification project (linuxtesting.org).
> 
> Signed-off-by: Alexey Khoroshilov <khoroshilov@...ras.ru>

Looks good, applied, thanks.