netdev - Re: [PATCH net-next 01/11] qede: Fix sparse warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170522.125430.1296201768191613727.davem@davemloft.net>
Date:   Mon, 22 May 2017 12:54:30 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     Yuval.Mintz@...ium.com
Cc:     netdev@...r.kernel.org, Manish.Chopra@...ium.com
Subject: Re: [PATCH net-next 01/11] qede: Fix sparse warnings

From: "Mintz, Yuval" <Yuval.Mintz@...ium.com>
Date: Mon, 22 May 2017 16:48:25 +0000

> 
> 
>> -----Original Message-----
>> From: David Miller [mailto:davem@...emloft.net]
>> Sent: Monday, May 22, 2017 7:38 PM
>> To: Mintz, Yuval <Yuval.Mintz@...ium.com>
>> Cc: netdev@...r.kernel.org; Chopra, Manish <Manish.Chopra@...ium.com>
>> Subject: Re: [PATCH net-next 01/11] qede: Fix sparse warnings
>> 
>> From: Yuval Mintz <Yuval.Mintz@...ium.com>
>> Date: Mon, 22 May 2017 14:32:01 +0300
>> 
>> > From: Manish Chopra <Manish.Chopra@...ium.com>
>> >
>> > Signed-off-by: Manish Chopra <Manish.Chopra@...ium.com>
>> > Signed-off-by: Yuval Mintz <Yuval.Mintz@...ium.com>
>> > ---
>> >  drivers/net/ethernet/qlogic/qede/qede_dcbnl.c   |  1 -
>> >  drivers/net/ethernet/qlogic/qede/qede_ethtool.c | 10 ++++++----
>> >  drivers/net/ethernet/qlogic/qede/qede_fp.c      | 25 ++++++++++++++-------
>> ----
>> >  drivers/net/ethernet/qlogic/qede/qede_roce.c    |  4 ++--
>> >  4 files changed, 22 insertions(+), 18 deletions(-)
>> >
>> > diff --git a/drivers/net/ethernet/qlogic/qede/qede_dcbnl.c
>> > b/drivers/net/ethernet/qlogic/qede/qede_dcbnl.c
>> > index a9e7379..6e7747b 100644
>> > --- a/drivers/net/ethernet/qlogic/qede/qede_dcbnl.c
>> > +++ b/drivers/net/ethernet/qlogic/qede/qede_dcbnl.c
>> > @@ -313,7 +313,6 @@ static int qede_dcbnl_ieee_peer_getets(struct
>> net_device *netdev,
>> >  	.ieee_setets = qede_dcbnl_ieee_setets,
>> >  	.ieee_getapp = qede_dcbnl_ieee_getapp,
>> >  	.ieee_setapp = qede_dcbnl_ieee_setapp,
>> > -	.getdcbx = qede_dcbnl_getdcbx,
>> >  	.ieee_peer_getpfc = qede_dcbnl_ieee_peer_getpfc,
>> >  	.ieee_peer_getets = qede_dcbnl_ieee_peer_getets,
>> >  	.getstate = qede_dcbnl_getstate,
>> 
>> Please.
>> 
>> This is exactly the problem when such a terse commit message, or lack of any
>> message at all as is the case here, occurs.
>> 
>> I have no idea what removing this method assignment has to do with fixing
>> sparse warnings.
> 
> It's currently defined twice in the qede_dcbnl_ops struct -

Ok, so what's important is that you don't just post a patch with no
commit message, just saying "sparse warning fixes."

At a minimum, if you're too lazy to explain what exactly each thing
is fixing, provide the sparse warnings you are eliminating in the
commit message.