netdev - Re: [patch net-next] net: sched: cls_matchall: fix null pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170522.145446.597984501091102550.davem@davemloft.net>
Date:   Mon, 22 May 2017 14:54:46 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     jiri@...nulli.us
Cc:     netdev@...r.kernel.org, jhs@...atatu.com, xiyou.wangcong@...il.com,
        mlxsw@...lanox.com, colin.king@...onical.com, yotamg@...lanox.com
Subject: Re: [patch net-next] net: sched: cls_matchall: fix null pointer
 dereference

From: Jiri Pirko <jiri@...nulli.us>
Date: Mon, 22 May 2017 16:46:13 +0200

> From: Jiri Pirko <jiri@...lanox.com>
> 
> Since the head is guaranteed by the check above to be null, the call_rcu
> would explode. Remove the previously logically dead code that was made
> logically very much alive and kicking.
> 
> Fixes: 985538eee06f ("net/sched: remove redundant null check on head")
> Signed-off-by: Jiri Pirko <jiri@...lanox.com>

Ouch... that's kinda scary.

This fix is needed in the 'net' tree so that's where I have applied
it.

Thanks.