netdev - Re: [PATCH] xprtrdma: Delete an error message for a failed memory allocation in xprt_rdma_bc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <DC0EF67A-4AF8-415A-8EC0-F86F8E6F08FE@oracle.com>
Date:   Mon, 22 May 2017 16:31:08 -0400
From:   Chuck Lever <chuck.lever@...cle.com>
To:     SF Markus Elfring <elfring@...rs.sourceforge.net>
Cc:     Linux NFS Mailing List <linux-nfs@...r.kernel.org>,
        netdev@...r.kernel.org, Anna Schumaker <anna.schumaker@...app.com>,
        "David S. Miller" <davem@...emloft.net>,
        "J. Bruce Fields" <bfields@...ldses.org>,
        Jeff Layton <jlayton@...chiereds.net>,
        Trond Myklebust <trond.myklebust@...marydata.com>,
        LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] xprtrdma: Delete an error message for a failed memory allocation in xprt_rdma_bc_setup()


> On May 22, 2017, at 4:24 PM, SF Markus Elfring <elfring@...rs.sourceforge.net> wrote:
> 
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Mon, 22 May 2017 22:18:28 +0200
> 
> Omit an extra message for a memory allocation failure in this function.
> 
> This issue was detected by using the Coccinelle software.
> 
> Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>

Reviewed-by: Chuck Lever <chuck.lever@...cle.com>


> ---
> net/sunrpc/xprtrdma/backchannel.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/net/sunrpc/xprtrdma/backchannel.c b/net/sunrpc/xprtrdma/backchannel.c
> index 24fedd4b117e..03f6b5840764 100644
> --- a/net/sunrpc/xprtrdma/backchannel.c
> +++ b/net/sunrpc/xprtrdma/backchannel.c
> @@ -119,11 +119,9 @@ int xprt_rdma_bc_setup(struct rpc_xprt *xprt, unsigned int reqs)
> 
> 	for (i = 0; i < (reqs << 1); i++) {
> 		rqst = kzalloc(sizeof(*rqst), GFP_KERNEL);
> -		if (!rqst) {
> -			pr_err("RPC:       %s: Failed to create bc rpc_rqst\n",
> -			       __func__);
> +		if (!rqst)
> 			goto out_free;
> -		}
> +
> 		dprintk("RPC:       %s: new rqst %p\n", __func__, rqst);
> 
> 		rqst->rq_xprt = &r_xprt->rx_xprt;
> -- 
> 2.13.0

--
Chuck Lever