netdev - [PATCH] Accept packets that the H.245 ALG can't process

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170522020753.16712-2-blair.steven@alliedtelesis.co.nz>
Date:   Mon, 22 May 2017 14:07:53 +1200
From:   Blair Steven <blair.steven@...iedtelesis.co.nz>
To:     netdev@...r.kernel.org
Cc:     Blair Steven <blair.steven@...iedtelesis.co.nz>
Subject: [PATCH] Accept packets that the H.245 ALG can't process

When two VoIP end points are configured differently (fast connect /
not fast connect) the ALG was failing to find a matching expectation
and dropping packets in one direction.

Dropping packets not the job of an ALG, and as such the behaviour
has been changed to allow the packet to be send to the forwarding
engine.

Signed-off-by: Blair Steven <blair.steven@...iedtelesis.co.nz>
---
 net/netfilter/nf_conntrack_h323_main.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/net/netfilter/nf_conntrack_h323_main.c b/net/netfilter/nf_conntrack_h323_main.c
index 3bcdc71..6161375 100644
--- a/net/netfilter/nf_conntrack_h323_main.c
+++ b/net/netfilter/nf_conntrack_h323_main.c
@@ -625,7 +625,7 @@ static int h245_help(struct sk_buff *skb, unsigned int protoff,
       drop:
 	spin_unlock_bh(&nf_h323_lock);
 	nf_ct_helper_log(skb, ct, "cannot process H.245 message");
-	return NF_DROP;
+	return NF_ACCEPT;
 }
 
 /****************************************************************************/
@@ -1200,7 +1200,7 @@ static int q931_help(struct sk_buff *skb, unsigned int protoff,
       drop:
 	spin_unlock_bh(&nf_h323_lock);
 	nf_ct_helper_log(skb, ct, "cannot process Q.931 message");
-	return NF_DROP;
+	return NF_ACCEPT;
 }
 
 /****************************************************************************/
@@ -1785,7 +1785,7 @@ static int ras_help(struct sk_buff *skb, unsigned int protoff,
       drop:
 	spin_unlock_bh(&nf_h323_lock);
 	nf_ct_helper_log(skb, ct, "cannot process RAS message");
-	return NF_DROP;
+	return NF_ACCEPT;
 }
 
 /****************************************************************************/
-- 
2.9.3