netdev - Re: [patch net-next 2/5] net: flow_dissector: add support for dissection of tcp flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <29df9132-b171-58fc-e943-9d6654867c57@mellanox.com>
Date:   Tue, 23 May 2017 18:18:33 +0300
From:   Or Gerlitz <ogerlitz@...lanox.com>
To:     Jiri Pirko <jiri@...nulli.us>
CC:     <netdev@...r.kernel.org>, <davem@...emloft.net>,
        <jhs@...atatu.com>, <xiyou.wangcong@...il.com>,
        <simon.horman@...ronome.com>, <mlxsw@...lanox.com>,
        <idosch@...lanox.com>
Subject: Re: [patch net-next 2/5] net: flow_dissector: add support for
 dissection of tcp flags

On 5/23/2017 5:31 PM, Jiri Pirko wrote:
> @@ -683,6 +708,12 @@ bool __skb_flow_dissect(const struct sk_buff *skb,
>   	case IPPROTO_MPLS:
>   		proto = htons(ETH_P_MPLS_UC);
>   		goto mpls;
> +	case IPPROTO_TCP:
> +		__skb_flow_dissect_tcp(skb, flow_dissector, target_container,
> +				       data, nhoff, hlen);
> +		/* Regardless of the return value, continue to process TCP
> +		 * ports dissection below.
> +		 */

the comment here is a bit misleading, since __skb_flow_dissect_tcp is void

other-wise

Acked-by: Or Gerlitz <ogerlitz@...lanox.com>