netdev - Re: [PATCH v2 0/4] arp: always override existing neigh entries with gratuitous ARP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a162_RdXHLCPzg47+F7yadRGMDgFG_z5R6v65-heY1KAw@mail.gmail.com>
Date:   Tue, 23 May 2017 22:56:31 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Ihar Hrachyshka <ihrachys@...hat.com>
Cc:     David Miller <davem@...emloft.net>, ja@....bg,
        Networking <netdev@...r.kernel.org>
Subject: Re: [PATCH v2 0/4] arp: always override existing neigh entries with
 gratuitous ARP

On Thu, May 18, 2017 at 9:41 PM, Ihar Hrachyshka <ihrachys@...hat.com> wrote:
> This patchset is spurred by discussion started at
> https://patchwork.ozlabs.org/patch/760372/ where we figured that there is no
> real reason for enforcing override by gratuitous ARP packets only when
> arp_accept is 1. Same should happen when it's 0 (the default value).
>
> changelog v2: handled review comments by Julian Anastasov
> - fixed a mistake in a comment;
> - postponed addr_type calculation to as late as possible.

This seems to have caused a build warning:

net/ipv4/arp.c:880:35: warning: 'addr_type' may be used uninitialized
in this function [-Wmaybe-uninitialized]

       Arnd