lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20170523112620.GA11795@hmswarspite.think-freely.org> Date: Tue, 23 May 2017 07:26:20 -0400 From: Neil Horman <nhorman@...driver.com> To: Xin Long <lucien.xin@...il.com> Cc: network dev <netdev@...r.kernel.org>, linux-sctp@...r.kernel.org, davem@...emloft.net, Marcelo Ricardo Leitner <marcelo.leitner@...il.com> Subject: Re: [PATCH net 1/2] sctp: fix stream update when processing dupcookie On Tue, May 23, 2017 at 01:28:54PM +0800, Xin Long wrote: > Since commit 3dbcc105d556 ("sctp: alloc stream info when initializing > asoc"), stream and stream.out info are always alloced when creating > an asoc. > > So it's not correct to check !asoc->stream before updating stream > info when processing dupcookie, but would be better to check asoc > state instead. > > Fixes: 3dbcc105d556 ("sctp: alloc stream info when initializing asoc") > Signed-off-by: Xin Long <lucien.xin@...il.com> > --- > net/sctp/associola.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/net/sctp/associola.c b/net/sctp/associola.c > index a9708da..9523828 100644 > --- a/net/sctp/associola.c > +++ b/net/sctp/associola.c > @@ -1176,7 +1176,9 @@ void sctp_assoc_update(struct sctp_association *asoc, > > asoc->ctsn_ack_point = asoc->next_tsn - 1; > asoc->adv_peer_ack_point = asoc->ctsn_ack_point; > - if (!asoc->stream) { > + > + if (sctp_state(asoc, COOKIE_WAIT)) { > + sctp_stream_free(asoc->stream); > asoc->stream = new->stream; > new->stream = NULL; > } > -- > 2.1.0 > > Acked-by: Neil Horman <nhorman@...driver.com>
Powered by blists - more mailing lists