lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <9B0331B6EBBD0E4684FBFAEDA55776F93D54F8DF@HASMSX110.ger.corp.intel.com> Date: Wed, 24 May 2017 19:33:33 +0000 From: "Rosen, Rami" <rami.rosen@...el.com> To: Roopa Prabhu <roopa@...ulusnetworks.com>, "davem@...emloft.net" <davem@...emloft.net> CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "dsahern@...il.com" <dsahern@...il.com>, "nikolay@...ulusnetworks.com" <nikolay@...ulusnetworks.com> Subject: RE: [PATCH net-next 1/8] net: ipv4: refactor __ip_route_output_key_hash Hi, Rupa /David Ahern, First, thanks for this patch set! Second, it seems to me that something might be incorrect here. You have these additions in this patch (1/8): ... +struct rtable *ip_route_output_key_hash_rcu(struct net *net, struct flowi4 *flp, + const struct sk_buff *skb, + struct fib_result *res); ... +struct rtable *ip_route_output_key_hash(struct net *net, struct flowi4 *fl4, + const struct sk_buff *skb) +{ + struct fib_result res; + struct rtable *rth; + + res.tclassid = 0; + res.fi = NULL; + res.table = NULL; + + rcu_read_lock(); + rth = ip_route_output_key_hash_rcu(net, fl4, &res, mp_hash); rcu_read_unlock(); + return rth; } -EXPORT_SYMBOL_GPL(__ip_route_output_key_hash); +EXPORT_SYMBOL_GPL(ip_route_output_key_hash); So the third parameter to ip_route_output_key_hash_rcu() should be skb*, and the fourth parameter should be fib_result *. However, you do not pass the skb parameter when calling ip_route_output_key_hash_rcu() in ip_route_output_key_hash() (in fact you don't use it at all), and you pass mp_hash as the fourth parameter. Regards, Rami Rosen Intel Corporation
Powered by blists - more mailing lists