netdev - Re: [PATCH net 1/3] bpf: fix incorrect pruning decision when alignment must be tracked

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5925EA56.3090404@iogearbox.net>
Date:   Wed, 24 May 2017 22:17:26 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     David Miller <davem@...emloft.net>
CC:     ast@...com, netdev@...r.kernel.org
Subject: Re: [PATCH net 1/3] bpf: fix incorrect pruning decision when alignment
 must be tracked

On 05/24/2017 10:07 PM, David Miller wrote:
> From: Daniel Borkmann <daniel@...earbox.net>
> Date: Tue, 23 May 2017 18:30:41 +0200
>
>> +	if (!env->strict_alignment && old->off <= cur->off &&
>
> You can't just test env->strict_alignment by itself, that's just an
> override and doesn't determine the actual "strict" value we use which
> is a combination of env->strict_alignment and
> "!CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS".
>
> So you'll have to update this test.

Argh, good point, true. Will respin with a v2.