netdev - Re: [PATCH 2/2] at803x: double check SGMII side autoneg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 24 May 2017 16:32:48 -0500
From:   Timur Tabi <timur@....qualcomm.com>
To:     Florian Fainelli <f.fainelli@...il.com>,
        Timur Tabi <timur@....qualcomm.com>,
        Andrew Lunn <andrew@...n.ch>
CC:     Matthias May <matthias.may@...atec.com>,
        Zefir Kurtisi <zefir.kurtisi@...atec.com>,
        <netdev@...r.kernel.org>, David Miller <davem@...emloft.net>,
        Manoj Iyer <manoj.iyer@...onical.com>, <jhugo@...eaurora.org>
Subject: Re: [PATCH 2/2] at803x: double check SGMII side autoneg

On 05/24/2017 04:28 PM, Florian Fainelli wrote:

> Yes phydev->lock which is used to serialize the state machine state changes.
>
> Most PHYs have many more registers than the 15 standard exposed
> directly, and so you need indirect reads/writes to access these
> registers, which typically involve switching a particular page, doing
> the indirect register access, and then flipping the page back. If you
> interrupt that scheme one way or another, your reads and writes are all
> messed up.

Ah, and the at803x is a device like that.

At worst, the autopoll feature could read a register from the wrong 
page, and think that the link state has changed when it hasn't.  But 
that's still bad, and all my problems do revolve around link states.

>> I forgot one detail.  Every time you do an MDIO read/write, it
>> temporarily disables the feature.  Although, I think that's not relevant
>> to your point.
>
> Is that done by the HW itself, or is this under SW control exclusively.

Software.