netdev - Re: [PATCH net-next 2/4] nfp: register ports as devlink ports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170524123514.GB1908@nanopsycho>
Date:   Wed, 24 May 2017 14:35:14 +0200
From:   Jiri Pirko <jiri@...nulli.us>
To:     Jakub Kicinski <jakub.kicinski@...ronome.com>
Cc:     netdev@...r.kernel.org, oss-drivers@...ronome.com
Subject: Re: [PATCH net-next 2/4] nfp: register ports as devlink ports

Tue, May 23, 2017 at 05:12:45PM CEST, jakub.kicinski@...ronome.com wrote:
>Extend nfp_port to contain devlink_port structures.  Register the
>ports to allow users inspecting device ports.
>
>Signed-off-by: Jakub Kicinski <jakub.kicinski@...ronome.com>
>Reviewed-by: Simon Horman <simon.horman@...ronome.com>
>---

[...]

>+void nfp_devlink_port_unregister(struct nfp_port *port)
>+{
>+	/* Due to unpleasant lock ordering we may see the port go away before
>+	 * we have fully probed.

Could you elaborate on this a bit more please?


>+	 */
>+	if (port->dl_port.registered)
>+		devlink_port_unregister(&port->dl_port);
>+}