lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20170524134422.7230F60DD9@smtp.codeaurora.org> Date: Wed, 24 May 2017 13:44:22 +0000 (UTC) From: Kalle Valo <kvalo@...eaurora.org> To: Kees Cook <keescook@...omium.org> Cc: netdev@...r.kernel.org, Joe Perches <joe@...ches.com>, libertas-dev@...ts.infradead.org, linux-wireless@...r.kernel.org, netdev@...r.kernel.org, Daniel Micay <danielmicay@...il.com>, linux-kernel@...r.kernel.org Subject: Re: [v3] libertas: Avoid reading past end of buffer Kees Cook <keescook@...omium.org> wrote: > Using memcpy() from a string that is shorter than the length copied means > the destination buffer is being filled with arbitrary data from the kernel > rodata segment. Instead, redefine the stat strings to be ETH_GSTRING_LEN > sizes, like other drivers. This lets us use a single memcpy that does not > leak rodata contents. Additionally adjust indentation to keep checkpatch.pl > happy. > > This was found with the future CONFIG_FORTIFY_SOURCE feature. > > Cc: Daniel Micay <danielmicay@...il.com> > Signed-off-by: Kees Cook <keescook@...omium.org> Patch applied to wireless-drivers-next.git, thanks. 12e3c0433e8a libertas: Avoid reading past end of buffer -- https://patchwork.kernel.org/patch/9727997/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Powered by blists - more mailing lists