| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20170524014950.3261-1-ap420073@gmail.com> Date: Wed, 24 May 2017 10:49:50 +0900 From: Taehee Yoo <ap420073@...il.com> To: davem@...emloft.net Cc: netdev@...r.kernel.org, Taehee Yoo <ap420073@...il.com> Subject: [PATCH] rhashtable: Fix missing elements when inserting. rhltable_insert_key() inserts a node into list of element, if node's key is duplicated, so that it becomes the chain of element(as known as rhead). Also bucket table points that element directly. If a inserted node's element chain is located at third, rhltable misses first and second element chain. This issue is causion of to failture the rhltable_remove(). After this patch, rhltable_insert_key() inserts a node into second of element's list, so that rhlist do not misses elements. Signed-off-by: Taehee Yoo <ap420073@...il.com> --- include/linux/rhashtable.h | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/include/linux/rhashtable.h b/include/linux/rhashtable.h index 7d56a7e..d3c24b9 100644 --- a/include/linux/rhashtable.h +++ b/include/linux/rhashtable.h @@ -762,11 +762,9 @@ static inline void *__rhashtable_insert_fast( list = container_of(obj, struct rhlist_head, rhead); plist = container_of(head, struct rhlist_head, rhead); - RCU_INIT_POINTER(list->next, plist); - head = rht_dereference_bucket(head->next, tbl, hash); - RCU_INIT_POINTER(list->rhead.next, head); - rcu_assign_pointer(*pprev, obj); - + RCU_INIT_POINTER(list->next, rht_dereference_bucket(plist->next, + tbl, hash)); + RCU_INIT_POINTER(plist->next, list); goto good; } -- 2.9.3
Powered by blists - more mailing lists