netdev - Re: [PATCH 0/2] Replace driver's usage of hard-coded device IDs to #defines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170524.200249.1492095559302424098.davem@davemloft.net>
Date:   Wed, 24 May 2017 20:02:49 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     myron.stowe@...hat.com
Cc:     linux-pci@...r.kernel.org, netdev@...r.kernel.org,
        bhelgaas@...gle.com, saeedm@...lanox.com, noaos@...lanox.com,
        tariqt@...lanox.com
Subject: Re: [PATCH 0/2] Replace driver's usage of hard-coded device IDs to
 #defines

From: Myron Stowe <myron.stowe@...hat.com>
Date: Wed, 24 May 2017 16:47:34 -0600

> Noa Osherovich introduced a series of new Mellanox device ID definitions to
> help differentiate specific controllers that needed INTx masking quirks [1].
> 
> Bjorn Helgaas followed on, using the device ID definitions Noa provided to
> replace hard-coded values within the mxl4 ID table [2].
>     
> This patch continues along similar lines, adding a few additional Mellanox
> device ID definitions and converting the net/mlx5e driver's mlx5 ID table to
> use the defines so tools like 'grep' and 'cscope' can be used to help
> identify relationships with other aspects (such as INTx masking).

If you're adding pci_ids.h defines, it's only valid to do so if you
actually use the defines in more than one location.

This patch series is not doing that.