netdev - Re: [PATCH net-next] ibmvnic: Enable TSO support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170525.144626.1787511445330790842.davem@davemloft.net>
Date:   Thu, 25 May 2017 14:46:26 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     tlfalcon@...ux.vnet.ibm.com
Cc:     netdev@...r.kernel.org, nfont@...ux.vnet.ibm.com,
        jallen@...ux.vnet.ibm.com
Subject: Re: [PATCH net-next] ibmvnic: Enable TSO support

From: Thomas Falcon <tlfalcon@...ux.vnet.ibm.com>
Date: Wed, 24 May 2017 21:29:26 -0500

> The feature is also enabled by a module parameter.
> This parameter is necessary because TSO can not easily be
> enabled or disabled in firmware without reinitializing the driver.

Sorry, this is unacceptable.  When I say no module parameters,
I really really mean it.

Users should not be burdoned with having to know a special knob for
every driver in order to adjust what is a generic feature.

You'll have to find another way to accomodate this.