netdev - Re: [PATCH net-next 6/6] net: mpls: minor cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170525.145631.1427287907712541949.davem@davemloft.net>
Date:   Thu, 25 May 2017 14:56:31 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     dsahern@...il.com
Cc:     netdev@...r.kernel.org, roopa@...ulusnetworks.com
Subject: Re: [PATCH net-next 6/6] net: mpls: minor cleanups

From: David Ahern <dsahern@...il.com>
Date: Wed, 24 May 2017 21:54:42 -0600

> Noticed these doing the extack support:
> - nla_get_via is only used in af_mpls.c so remove from internal.h
 ...
> @@ -43,6 +43,9 @@ static void rtmsg_lfib(int event, u32 label, struct mpls_route *rt,
>  		       struct nlmsghdr *nlh, struct net *net, u32 portid,
>  		       unsigned int nlm_flags);
>  
> +static int nla_get_via(const struct nlattr *nla, u8 *via_alen, u8 *via_table,
> +		       u8 via[], struct netlink_ext_ack *extack);
> +
>  static struct mpls_route *mpls_route_input_rcu(struct net *net, unsigned index)
>  {
>  	struct mpls_route *rt = NULL;

David, please mark the actual defintion static as well.

I'm surprised the compiler accepts this, but it does :-)