| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <201705251041.sznZ0knO%fengguang.wu@intel.com>
Date: Thu, 25 May 2017 10:38:02 +0800
From: kbuild test robot <lkp@...el.com>
To: Roopa Prabhu <roopa@...ulusnetworks.com>
Cc: kbuild-all@...org, davem@...emloft.net, netdev@...r.kernel.org,
dsahern@...il.com, nikolay@...ulusnetworks.com
Subject: Re: [PATCH net-next 1/8] net: ipv4: refactor
__ip_route_output_key_hash
Hi David,
[auto build test ERROR on net-next/master]
url: https://github.com/0day-ci/linux/commits/Roopa-Prabhu/net-extend-RTM_GETROUTE-to-return-fib-result/20170525-053253
config: openrisc-or1ksim_defconfig (attached as .config)
compiler: or1k-linux-gcc (GCC) 5.4.0
reproduce:
wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=openrisc
Note: the linux-review/Roopa-Prabhu/net-extend-RTM_GETROUTE-to-return-fib-result/20170525-053253 HEAD 083c4ee9e124d0acf29d159ced8a22cb41665a7a builds fine.
It only hurts bisectibility.
All errors (new ones prefixed by >>):
In file included from include/net/route.h:31:0,
from include/net/lwtunnel.h:8,
from include/net/ip_tunnels.h:17,
from include/net/dst_metadata.h:5,
from net/ipv4/route.c:94:
net/ipv4/route.c: In function 'ip_route_output_key_hash_rcu':
>> include/net/ip_fib.h:167:32: error: request for member 'fi' in something not a structure or union
#define FIB_RES_NH(res) ((res).fi->fib_nh[0])
^
include/net/ip_fib.h:196:28: note: in expansion of macro 'FIB_RES_NH'
#define FIB_RES_DEV(res) (FIB_RES_NH(res).nh_dev)
^
net/ipv4/route.c:2399:35: note: in expansion of macro 'FIB_RES_DEV'
dev_out = l3mdev_master_dev_rcu(FIB_RES_DEV(res)) ? :
^
net/ipv4/route.c: In function 'ip_route_output_key_hash':
net/ipv4/route.c:2430:53: error: 'mp_hash' undeclared (first use in this function)
rth = ip_route_output_key_hash_rcu(net, fl4, &res, mp_hash);
^
net/ipv4/route.c:2430:53: note: each undeclared identifier is reported only once for each function it appears in
net/ipv4/route.c:2430:47: error: passing argument 3 of 'ip_route_output_key_hash_rcu' from incompatible pointer type [-Werror=incompatible-pointer-types]
rth = ip_route_output_key_hash_rcu(net, fl4, &res, mp_hash);
^
net/ipv4/route.c:2249:16: note: expected 'const struct sk_buff *' but argument is of type 'struct fib_result *'
struct rtable *ip_route_output_key_hash_rcu(struct net *net, struct flowi4 *fl4,
^
cc1: some warnings being treated as errors
--
In file included from include/net/route.h:31:0,
from include/net/lwtunnel.h:8,
from include/net/ip_tunnels.h:17,
from include/net/dst_metadata.h:5,
from net//ipv4/route.c:94:
net//ipv4/route.c: In function 'ip_route_output_key_hash_rcu':
>> include/net/ip_fib.h:167:32: error: request for member 'fi' in something not a structure or union
#define FIB_RES_NH(res) ((res).fi->fib_nh[0])
^
include/net/ip_fib.h:196:28: note: in expansion of macro 'FIB_RES_NH'
#define FIB_RES_DEV(res) (FIB_RES_NH(res).nh_dev)
^
net//ipv4/route.c:2399:35: note: in expansion of macro 'FIB_RES_DEV'
dev_out = l3mdev_master_dev_rcu(FIB_RES_DEV(res)) ? :
^
net//ipv4/route.c: In function 'ip_route_output_key_hash':
net//ipv4/route.c:2430:53: error: 'mp_hash' undeclared (first use in this function)
rth = ip_route_output_key_hash_rcu(net, fl4, &res, mp_hash);
^
net//ipv4/route.c:2430:53: note: each undeclared identifier is reported only once for each function it appears in
net//ipv4/route.c:2430:47: error: passing argument 3 of 'ip_route_output_key_hash_rcu' from incompatible pointer type [-Werror=incompatible-pointer-types]
rth = ip_route_output_key_hash_rcu(net, fl4, &res, mp_hash);
^
net//ipv4/route.c:2249:16: note: expected 'const struct sk_buff *' but argument is of type 'struct fib_result *'
struct rtable *ip_route_output_key_hash_rcu(struct net *net, struct flowi4 *fl4,
^
cc1: some warnings being treated as errors
vim +/fi +167 include/net/ip_fib.h
5f300893f Thomas Graf 2006-11-09 151 u32 fl_mark;
246955fe4 Robert Olsson 2005-06-20 152 unsigned char fl_tos;
246955fe4 Robert Olsson 2005-06-20 153 unsigned char fl_scope;
246955fe4 Robert Olsson 2005-06-20 154 unsigned char tb_id_in;
246955fe4 Robert Olsson 2005-06-20 155
246955fe4 Robert Olsson 2005-06-20 156 unsigned char tb_id; /* Results */
246955fe4 Robert Olsson 2005-06-20 157 unsigned char prefixlen;
246955fe4 Robert Olsson 2005-06-20 158 unsigned char nh_sel;
246955fe4 Robert Olsson 2005-06-20 159 unsigned char type;
246955fe4 Robert Olsson 2005-06-20 160 unsigned char scope;
246955fe4 Robert Olsson 2005-06-20 161 int err;
246955fe4 Robert Olsson 2005-06-20 162 };
^1da177e4 Linus Torvalds 2005-04-16 163
^1da177e4 Linus Torvalds 2005-04-16 164 #ifdef CONFIG_IP_ROUTE_MULTIPATH
^1da177e4 Linus Torvalds 2005-04-16 165 #define FIB_RES_NH(res) ((res).fi->fib_nh[(res).nh_sel])
^1da177e4 Linus Torvalds 2005-04-16 166 #else /* CONFIG_IP_ROUTE_MULTIPATH */
^1da177e4 Linus Torvalds 2005-04-16 @167 #define FIB_RES_NH(res) ((res).fi->fib_nh[0])
5b9e12dbf Denis V. Lunev 2013-03-13 168 #endif /* CONFIG_IP_ROUTE_MULTIPATH */
^1da177e4 Linus Torvalds 2005-04-16 169
5b9e12dbf Denis V. Lunev 2013-03-13 170 #ifdef CONFIG_IP_MULTIPLE_TABLES
93456b6d7 Denis V. Lunev 2008-01-10 171 #define FIB_TABLE_HASHSZ 256
5b9e12dbf Denis V. Lunev 2013-03-13 172 #else
5b9e12dbf Denis V. Lunev 2013-03-13 173 #define FIB_TABLE_HASHSZ 2
5b9e12dbf Denis V. Lunev 2013-03-13 174 #endif
^1da177e4 Linus Torvalds 2005-04-16 175
:::::: The code at line 167 was first introduced by commit
:::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2
:::::: TO: Linus Torvalds <torvalds@...970.osdl.org>
:::::: CC: Linus Torvalds <torvalds@...970.osdl.org>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
Download attachment ".config.gz" of type "application/gzip" (7551 bytes)
Powered by blists - more mailing lists