lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20170525135624.z723srd7evhml5e3@bars> Date: Thu, 25 May 2017 16:56:24 +0300 From: Sergey Matyukevich <sergey.matyukevich.os@...ntenna.com> To: Colin King <colin.king@...onical.com> Cc: Avinash Patil <avinashp@...ntenna.com>, Sergey Matyukevich <sergey.matyukevich.os@...ntenna.com>, Igor Mitsyanko <igor.mitsyanko.os@...ntenna.com>, Kalle Valo <kvalo@...eaurora.org>, Huizhao Wang <hwang@...ntenna.com>, Kamlesh Rath <krath@...ntenna.com>, linux-wireless@...r.kernel.org, netdev@...r.kernel.org, kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH][net-next] qtnfmac: remove duplicated assignment to mac > mac is being assigned twice, remove redundant 2nd assignment. > > Detected by CoverityScan, CID#1437554 ("Incorrect expression") > > Signed-off-by: Colin Ian King <colin.king@...onical.com> > --- > drivers/net/wireless/quantenna/qtnfmac/cfg80211.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c b/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c > index fc0ce2c09097..e3c090008125 100644 > --- a/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c > +++ b/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c > @@ -922,7 +922,7 @@ void qtnf_netdev_updown(struct net_device *ndev, bool up) > void qtnf_virtual_intf_cleanup(struct net_device *ndev) > { > struct qtnf_vif *vif = qtnf_netdev_get_priv(ndev); > - struct qtnf_wmac *mac = mac = wiphy_priv(vif->wdev.wiphy); > + struct qtnf_wmac *mac = wiphy_priv(vif->wdev.wiphy); Thanks ! Acked-by: Sergey Matyukevich <sergey.matyukevich.os@...ntenna.com>
Powered by blists - more mailing lists