netdev - Re: [PATCH net-next] tcp: better validation of received ack sequences

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170525.124817.1960721450872387047.davem@davemloft.net>
Date:   Thu, 25 May 2017 12:48:17 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     eric.dumazet@...il.com
Cc:     p.fiterau-brostean@...ence.ru.nl, netdev@...r.kernel.org,
        F.Vaandrager@...ru.nl, ncardwell@...gle.com, ycheng@...gle.com,
        soheil@...gle.com
Subject: Re: [PATCH net-next] tcp: better validation of received ack
 sequences

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Tue, 23 May 2017 15:24:46 -0700

> Add a FLAG_NO_CHALLENGE_ACK so that tcp_rcv_state_process()
> can choose to send a challenge ACK and discard the packet instead
> of wrongly change socket state.

Applied, but the tests end up being double-negatives so it might
have been easier to understand if the flag was a positive rather
than a negative value.