netdev - Re: [PATCH] arp: fixed -Wuninitialized compiler warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170525.133857.899186405679934528.davem@davemloft.net>
Date:   Thu, 25 May 2017 13:38:57 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     ihrachys@...hat.com
Cc:     ja@....bg, netdev@...r.kernel.org
Subject: Re: [PATCH] arp: fixed -Wuninitialized compiler warning

From: Ihar Hrachyshka <ihrachys@...hat.com>
Date: Wed, 24 May 2017 15:19:35 -0700

> Commit 7d472a59c0e5ec117220a05de6b370447fb6cb66 ("arp: always override
> existing neigh entries with gratuitous ARP") introduced a compiler
> warning:
> 
> net/ipv4/arp.c:880:35: warning: 'addr_type' may be used uninitialized in
> this function [-Wmaybe-uninitialized]
> 
> While the code logic seems to be correct and doesn't allow the variable
> to be used uninitialized, and the warning is not consistently
> reproducible, it's still worth fixing it for other people not to waste
> time looking at the warning in case it pops up in the build environment.
> Yes, compiler is probably at fault, but we will need to accommodate.
> 
> Fixes: 7d472a59c0e5ec117220a05de6b370447fb6cb66
> Signed-off-by: Ihar Hrachyshka <ihrachys@...hat.com>

Applied, but please in the future format your Fixes: tag properly
which should have been:

Fixes: 7d472a59c0e5 ("arp: always override existing neigh entries with gratuitous ARP")

Thanks.