netdev - Re: [PATCH 1/5] MIPS: Optimize uasm insn lookup.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f4472a45-a67b-763f-fffc-26fdc9fa27b4@caviumnetworks.com>
Date:   Fri, 26 May 2017 11:25:14 -0700
From:   David Daney <ddaney@...iumnetworks.com>
To:     Matt Redfearn <matt.redfearn@...tec.com>,
        David Daney <david.daney@...ium.com>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-mips@...ux-mips.org,
        ralf@...ux-mips.org
Subject: Re: [PATCH 1/5] MIPS: Optimize uasm insn lookup.

On 05/26/2017 01:07 AM, Matt Redfearn wrote:
[...]
>> -    { insn_lwx, 0, 0 },
>> -    { insn_ldx, 0, 0 },
>> -    { insn_invalid, 0, 0 }
>> +static struct insn insn_table_MM[insn_invalid] = {
> 
> ^ You could make this const too, like you have the one in uasm-mips.c.
> 

Good catch.  I meant to do that.

I will fix it for the next revision of the patch set.



> Thanks,
> Matt
>