netdev - Re: [PATCH net-next] liquidio: fix rare pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170526.144235.1508311899416004009.davem@davemloft.net>
Date:   Fri, 26 May 2017 14:42:35 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     felix.manlunas@...ium.com
Cc:     netdev@...r.kernel.org, raghu.vatsavayi@...ium.com,
        derek.chickles@...ium.com, satananda.burla@...ium.com,
        prasad.kanneganti@...ium.com
Subject: Re: [PATCH net-next] liquidio: fix rare pci_driver.probe failure
 of VF driver

From: Felix Manlunas <felix.manlunas@...ium.com>
Date: Thu, 25 May 2017 10:42:14 -0700

> From: Prasad Kanneganti <prasad.kanneganti@...ium.com>
> 
> There's a rare pci_driver.probe failure of the VF driver that's caused by
> PF/VF handshake going out of sync.  The culprit is octeon_mbox_write() who
> ignores an ack timeout condition; it just keeps unconditionally writing all
> elements of mbox_cmd->data[] even when the other side is not ready for
> them.  Fix it by making each write of mbox_cmd->data[i] conditional to
> having previously received an ack.
> 
> Also fix the octeon_mbox_state enum such that each state gets a unique
> value.  Also add ULL suffix to numeric literals in macro definitions.
> 
> Signed-off-by: Prasad Kanneganti <prasad.kanneganti@...ium.com>
> Signed-off-by: Felix Manlunas <felix.manlunas@...ium.com>

Applied.