netdev - Re: [PATCH net-next 3/4] tls: kernel TLS support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1495808219.6465.118.camel@edumazet-glaptop3.roam.corp.google.com>
Date:   Fri, 26 May 2017 07:16:59 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Dave Watson <davejwatson@...com>
Cc:     Ilya Lesokhin <ilyal@...lanox.com>,
        Aviad Yehezkel <aviadye@...lanox.com>,
        Boris Pismenny <borisp@...lanox.com>,
        Liran Liss <liranl@...lanox.com>,
        Matan Barak <matanb@...lanox.com>,
        David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
        Tom Herbert <tom@...bertland.com>, herbert@...dor.apana.org.au,
        linux-crypto@...r.kernel.org,
        Hannes Frederic Sowa <hannes@...essinduktion.org>,
        Alexei Starovoitov <alexei.starovoitov@...il.com>,
        nmav@...lts.org, fridolin.pokorny@...il.com
Subject: Re: [PATCH net-next 3/4] tls: kernel TLS support

On Wed, 2017-05-24 at 09:27 -0700, Dave Watson wrote:
> Software implementation of transport layer security, implemented using ULP
> infrastructure.  tcp proto_ops are replaced with tls equivalents of sendmsg and
> sendpage.

...

> +
> +int tls_sw_sendmsg(struct sock *sk, struct msghdr *msg, size_t size)
> +{
	...
> +
> +	lock_sock(sk);
> +
> +	/* Only one writer at a time is allowed */
> +	if (sk->sk_write_pending)
> +		return -EBUSY;

Ouch...