netdev - Re: [patch net-next] net/sched: let chain_get to figure out the return value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170526.105912.229870645071385383.davem@davemloft.net>
Date:   Fri, 26 May 2017 10:59:12 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     jiri@...nulli.us
Cc:     netdev@...r.kernel.org, jhs@...atatu.com, xiyou.wangcong@...il.com,
        mlxsw@...lanox.com
Subject: Re: [patch net-next] net/sched: let chain_get to figure out the
 return value

From: Jiri Pirko <jiri@...nulli.us>
Date: Fri, 26 May 2017 09:21:29 +0200

> From: Jiri Pirko <jiri@...lanox.com>
> 
> Alhough I believe that this create/nocreate dance is completelly
> pointless, at least make it a bit nicer and easier to read.
> Push the decision on what error value is returned to chain_get function
> and use ERR macros.
> 
> Signed-off-by: Jiri Pirko <jiri@...lanox.com>

No, this is quite worse.

You're leaving pointer error values in structures.  That's extremely
error prone.

And as stated in the other thread, I don't think Cong's logic is strange
or hard to understand at all.