netdev - Re: [PATCH net-next] net: ndisc.c: reduce size of __ndisc_fill_addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170527151514.GA3347@avx2>
Date:   Sat, 27 May 2017 18:15:14 +0300
From:   Alexey Dobriyan <adobriyan@...il.com>
To:     Linyu.Yuan@...atel-sbell.com.cn
Cc:     netdev@...r.kernel.org, davem@...emloft.net
Subject: Re: [PATCH net-next] net: ndisc.c: reduce size of
 __ndisc_fill_addr_option()

> --- a/net/ipv6/ndisc.c
> +++ b/net/ipv6/ndisc.c
> @@ -148,17 +148,18 @@ void __ndisc_fill_addr_option(struct sk_buff *skb, int type, void *data,

>  	space -= data_len;
> -	if (space > 0)
> -		memset(opt, 0, space);
> +
> +	memset(opt, 0, space);

This can't be right.

And what size are you reducing?